Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of tests where the only issue is that the new resolver gives a different message than the old resolver. I've taken the view that changing the test to reflect what the new resolver says is acceptable, at least in the short term.
It's very arguable that the correct approach is actually to make the new resolver give the "correct" message, but it's not clear to me that this would be straightforward to do, and as we have a UX project working on the broarder task of improving pip's messages, it seems reasonable to make a tactical fix for now. If nothing else, the test code will pinpoint where and how the messages differ between the two resolvers, and we can use that as a starting point for any further improvements.
It's not obvious to me to what extent the existing messages are based on implementation details of the old resolver (in which case, it's fair game to change them based on implementation details of the new resolver) or on a conscious decision to display a particular message to the user (in which case we probably should make more effort to review if the new message is an acceptable alternative). But my inclination is to address that sort of question in follow-up PRs, once we have the test suite failures dealt with.
Opinions, anyone? @pradyunsg @uranusjr @brainwane @ei8fdb @nlhkabu