fix(network/auth): Asks for password when it is None #8027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged? |
|
It needs a review first (I don't personally know the keyring code well enough, but from a technical point of view the change looks OK to me). But even so, merges are on hold until after 20.1 is released. Unless this is viewed as a significant bugfix, worth an exemption, but that would be @pradyunsg's call, as RM. |
uranusjr
reviewed
Apr 23, 2020
uranusjr
reviewed
Apr 23, 2020
uranusjr
approved these changes
Apr 23, 2020
|
Can this be merged now? |
pradyunsg
reviewed
May 14, 2020
news/7998.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Ask for password when either the password is None. | |||
There was a problem hiding this comment.
This probably needs to be reworded. It's not very clear what this means as a line in https://pip.pypa.io/en/stable/news/.
I'm not sure what the best phrasing would be, but perhaps someone else would have a suggestion.
There was a problem hiding this comment.
How about Prompt the user for password if the keyring backend doesn't return one
When `get_keyring_auth` provides the password as None, the user should be prompt to ask password.
pradyunsg
approved these changes
May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
get_keyring_authprovides the password as None, theuser should be prompt to ask the password.
This fixes #7998