Split relative requirement install tests #7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us make better use of parallelization and will let us remove the unnecessary uninstallation from these individual tests.
Since a new temporary script path is used for each test, no need to do uninstall.
chrahunt
added
C: tests
pradyunsg
approved these changes
Jan 13, 2020
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_basic_install_relative_directoryandtest_relative_requirements_fileare some of our longest tests (as indicated in our test summary in Azure Pipelines, e.g. here). This isn't because they're doing anything special, just a simple thing several times, requiringpip uninstallin-between runs in the same test.Now we run the tests individually and can drop the unnecessary
pip uninstallwhich saving some time (4s on my machine single-threaded). This also allows these individual tests to be run concurrently when using pytest-xdist.Progresses #4497.