Switch to packaging.tags.mac_version for macOS wheel tag backfilling #7561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
pradyunsg
approved these changes
Jan 7, 2020
Makes the next change easier to review.
This function takes care of the version iteration AND architecture determination internally.
chrahunt
force-pushed
the
maint/use-packaging-tags-mac-versions
branch
from
f3a220e to
bc20a98
Compare
pradyunsg
approved these changes
Jan 7, 2020
xavfernandez
reviewed
Jan 7, 2020
pradyunsg
removed
the
skip news
|
(dropped the trivial label, based on @xavfernandez's review comment) |
xavfernandez
added
the
skip news
xavfernandez
approved these changes
Jan 7, 2020
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #6908. Split from #7354.