Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused noarch flag in pep425tags.get_supported #7304

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Remove unused noarch flag in pep425tags.get_supported #7304

merged 1 commit into from
Nov 7, 2019

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Nov 6, 2019 •
edited
Loading

Progresses #6908.

@chrahunt chrahunt added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Nov 6, 2019
@chrahunt chrahunt marked this pull request as ready for review November 6, 2019 03:15
@pradyunsg
Copy link
Member

pradyunsg commented Nov 6, 2019 •
edited
Loading

nit: git is pretty bad at anchoring diff when there's dedentation -- I would've made a separate commit removing the noarch parameter and changing the conditional to True, then the next one would dedent the whole block.

@chrahunt
Copy link
Member Author

chrahunt commented Nov 6, 2019

Ignoring whitespace in the diff can serve a similar purpose. I checked that first and thought it would be easy enough to review.

@pradyunsg
Copy link
Member

Yea, makes sense. It was just nitpick tho. :)

@chrahunt chrahunt merged commit 53770a7 into pypa:master Nov 7, 2019
@chrahunt chrahunt deleted the refactor/remove-unused-noarch branch November 7, 2019 00:34
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrahunt @pradyunsg @xavfernandez