Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Link.is_hash_allowed() to accept hashes=None #6774

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Update Link.is_hash_allowed() to accept hashes=None #6774

merged 1 commit into from
Jul 23, 2019

Conversation

cjerdonek
Copy link
Member

Fixes #6772.

@cjerdonek cjerdonek mentioned this pull request Jul 23, 2019
Closed
@cjerdonek cjerdonek force-pushed the issue-6772-is-hash-allowed-none-error branch from 5f4d711 to 0a1571b Compare July 23, 2019 09:23
@cjerdonek
Copy link
Member Author

I also reproduced the AttributeError on my machine when running pip list --outdated and confirmed that the error went away with the given patch.

@pradyunsg pradyunsg merged commit 81040b5 into pypa:master Jul 23, 2019
@pradyunsg pradyunsg changed the title Fix #6772: Update Link.is_hash_allowed() to accept None hashes Update Link.is_hash_allowed() to accept hashes=None Jul 23, 2019
@atugushev atugushev mentioned this pull request Jul 23, 2019
Merged
7 tasks
@cjerdonek cjerdonek deleted the issue-6772-is-hash-allowed-none-error branch July 24, 2019 01:54
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'is_hash_allowed'
2 participants
@cjerdonek @pradyunsg