Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whether to build wheels is no longer affected by --no-cache-dir. #6303

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Whether to build wheels is no longer affected by --no-cache-dir. #6303

merged 2 commits into from
Feb 28, 2019

Conversation

cjerdonek
Copy link
Member

Fixes #5749.

@cjerdonek cjerdonek mentioned this pull request Feb 27, 2019
Closed
@cjerdonek
Copy link
Member Author

Also, I tested this locally, and it works (both with and without the patch, confirming the change in behavior).

@cjerdonek cjerdonek added type: enhancement Improvements to functionality C: wheel The wheel format and 'pip wheel' command C: cache Dealing with cache and files in it labels Feb 27, 2019
@ihnorton
Copy link

Tested with my use-case mentioned in #5749, and it works well. Thank you!

@ihnorton ihnorton mentioned this pull request Feb 27, 2019
Closed
@cjerdonek cjerdonek force-pushed the issue-5749-no-cache-dir branch from cd5e669 to a2ed253 Compare February 28, 2019 04:40
@cjerdonek
Copy link
Member Author

@pradyunsg Okay, I split the commit into two.

@pradyunsg pradyunsg merged commit df80be3 into pypa:master Feb 28, 2019
@cjerdonek cjerdonek deleted the issue-5749-no-cache-dir branch February 28, 2019 09:23
@jakirkham jakirkham mentioned this pull request Feb 28, 2019
Closed
@lock
Copy link

lock bot commented May 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: cache Dealing with cache and files in it C: wheel The wheel format and 'pip wheel' command type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing --no-cache-dir should not affect whether to use a wheel
3 participants
@cjerdonek @ihnorton @pradyunsg