Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show Python 2.7 EOL date on CPython. #6208

Merged
merged 1 commit into from
Feb 2, 2019

Conversation

Julian
Copy link
Contributor

@Julian Julian commented Jan 27, 2019

Other Python implementations, notably PyPy, are not EOL'ing on January
1, 2020.

I've left the core of the warning intact, and have just found https://discuss.python.org/t/packaging-and-python-2/662/73 about pip's own plans (obviously my hope would be that pip does continue to support py2, but will follow that along).

Closes: #6207

@cjerdonek cjerdonek added the type: deprecation Related to deprecation / removal. label Jan 28, 2019
Copy link

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @pradyunsg @dstufft @pfmoore however given that most users are stuck on Python 2 because of their system limitations, not their personal choice, maybe we should drop the message entirely. Guido seems to agree towards this too.

@Julian
Copy link
Contributor Author

Julian commented Jan 28, 2019

So as I mentioned on the other issue, in case my vote counts :), assuming pip has no concrete plans to drop Py2 support, I'd personally:

  • Show the warning exactly as is on CPython
  • Show no warning whatsoever on any other interpreter (or at least on PyPy)

with the reasoning being that whether they like it or not, users using CPython do need to consider EOL (whether pip is the right thing to warn about that who knows, which maybe is the argument to drop it entirely, but I hope something does show one...)

Users using PyPy (well me) do not need to worry about EOL, there isn't one, and our support is continuing for now. If pip plans to drop support for Py2 in any reasonable timeline (say, the next 2 years?) then I'd want to see a warning saying so, because that we would want to plan for (by probably just freezing to the last version pip supports us on).

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will include in 19.0.2.

Copy link
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a .bugfix news file be added since this is a user-visible change, and I think the distinction is worth highlighting in the release notes?

Other Python implementations, notably PyPy, are not EOL'ing on January
1, 2020.
@Julian
Copy link
Contributor Author

Julian commented Jan 31, 2019

@cjerdonek done

@pradyunsg
Copy link
Member

@gaborbernat:

maybe we should drop the message entirely

I'm inclined to add an option and suggest in the message how to suppress the message itself, using pip config. I remember seeing git do this when deprecating / changing behavior (though I'm not sure what it was for).

@cjerdonek
Copy link
Member

I'm inclined to add an option and suggest in the message how to suppress the message itself, using pip config.

@pradyunsg Is it okay to discuss this in a separate issue / PR so this can be merged?

@pradyunsg
Copy link
Member

@pradyunsg Is it okay to discuss this in a separate issue / PR so this can be merged?

Yea, definitely.

@pradyunsg pradyunsg merged commit fbc92b3 into pypa:master Feb 2, 2019
@Julian Julian deleted the python27-warning branch February 3, 2019 18:25
@lock
Copy link

lock bot commented May 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: deprecation Related to deprecation / removal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The warning message for Python 2.7 EOL is shown even for Pythons that are not EOL'ing
4 participants