pip list --not-required --outdated should list only outdated packages… #6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that are not dependencies of installed packages
peterlisak
force-pushed
the
bug-fix-outdated-not-required
branch
from
dcccea6 to
4f35981
Compare
xavfernandez
reviewed
Jan 7, 2019
tests/functional/test_list.py
Outdated
| @@ -384,6 +384,22 @@ def test_outdated_editables_columns_flag(script, data): | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.network | |||
There was a problem hiding this comment.
Since you are using --no-index option, this mark should not be necessary.
| @@ -134,14 +134,14 @@ def run(self, options, args): | |||
| include_editables=options.include_editable, | |||
| ) | |||
|
|
|||
| if options.not_required: | |||
| packages = self.get_not_required(packages, options) | |||
There was a problem hiding this comment.
Maybe add a comment explaining why this should stay before the other filter operations.
There was a problem hiding this comment.
Thanks for comments. The explanation added.
xavfernandez
approved these changes
Jan 7, 2019
|
Thanks for the PR 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #5737. Filtering out of not-required packages should be done before getting outdated here:
pip/src/pip/_internal/commands/list.py
Lines 136 to 144 in 740b1ac
Current behaviour, for example: Outdated package B is required by up-to-date package A. The list of outdated packages passed to
self.get_not_requiredcontains only package B. Therefore package B is not detected as the requirement of any other package in the list and therefore is not considered as dependency.