Fixes for the cases that raise Tracebacks in outdated pip version check #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
force-pushed
the
bugfix/errors-in-outdated-check
branch
from
c838698 to
9019ed5
Compare
|
Any reason to just not cache the check, but otherwise still perform it when the cache is disabled? |
|
Ah. Oversight. :) I'll see what to do for that. #5680 should be close enough in that case. |
pradyunsg
force-pushed
the
bugfix/errors-in-outdated-check
branch
from
9019ed5 to
692929e
Compare
pradyunsg
changed the title
pradyunsg
force-pushed
the
bugfix/errors-in-outdated-check
branch
from
692929e to
1e0247f
Compare
|
Updated the description according to the updated PR. Fixes all the same issues as before. |
|
CI passes and I am happy with these changes. I'll go ahead and merge this. |
|
When is the next release due? This is the only issue blocking my team to upgrade pip to 18.x |
|
@nehaljwani: soon: #5782. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5679. The
selfcheck.jsonfile is stored in the cache. If the cache is disabled, this file can not be accessed and so pip shouldn't cache the version in that case.Fixes #5433 (and closes #5680). Instead of performing the version check for every command, only perform the check with commands have the required (index) options.