Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify linter use and make configuration consistent #5530

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Simplify linter use and make configuration consistent #5530

merged 2 commits into from
Jul 4, 2018

Conversation

pradyunsg
Copy link
Member

  • Moves ignoring logic to configuration, expanding the scope to cover files not previously covered.
  • Makes running flake8 and isort as simple as running flake8 and isort locally, if the dev environment is setup correctly.
  • Config files look slightly cleaner. ✨

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Jun 25, 2018
@pradyunsg pradyunsg added this to the Internal Cleansing milestone Jun 25, 2018
@pradyunsg pradyunsg self-assigned this Jun 25, 2018
@pradyunsg pradyunsg requested a review from a team June 25, 2018 11:38
@pradyunsg pradyunsg merged commit 4ba6769 into pypa:master Jul 4, 2018
@pradyunsg pradyunsg deleted the misc/simplify-linter-use branch July 4, 2018 08:57
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees

@pradyunsg pradyunsg

Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
Internal Cleansing
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyunsg @xavfernandez