Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run setup.py develop inside of PEP 518 build environment #4999

Merged
merged 22 commits into from Mar 2, 2018
+23 −13
Merged

Run setup.py develop inside of PEP 518 build environment #4999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d0c42d3
Ignore .vscode
xoviat Jan 26, 2018
6a99774
Add cleanup method to build_env
xoviat Jan 26, 2018
615de6a
Pass through finder to prepare operation
xoviat Jan 26, 2018
08bec25
More eagerly cleanup the requirement
xoviat Jan 26, 2018
958a936
Make BuildEnvironment a proprety of Requirement
xoviat Jan 26, 2018
27cb7f3
Install build requirements in the prepare operation
xoviat Jan 26, 2018
8dad780
Address review comments
xoviat Jan 27, 2018
d3d13ea
:art:
xoviat Jan 27, 2018
3b88968
:art:
xoviat Jan 27, 2018
74c086b
:art:
xoviat Jan 27, 2018
5bb4e76
:news:
xoviat Jan 27, 2018
b214425
Add regression test
xoviat Jan 27, 2018
12202ee
Fix regression
xoviat Jan 27, 2018
5c77300
Fix regression test
xoviat Jan 27, 2018
8810500
Address review
xoviat Jan 27, 2018
1601ebb
revert .gitignore
xoviat Jan 27, 2018
60a7a8f
Run 'setup.py develop' in the build environment
xoviat Jan 28, 2018
736cd67
Add regression test
xoviat Jan 28, 2018
9280d17
Download setuptools and wheel to packages
xoviat Jan 28, 2018
55458fc
Merge branch 'master' into pep518-editable
xoviat Mar 1, 2018
76f62b7
:art:
xoviat Mar 1, 2018
2025f7f
:newspaper:
xoviat Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/4999.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Run 'setup.py develop' inside pep518 build environment.
27 changes: 14 additions & 13 deletions src/pip/_internal/req/req_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,19 +897,20 @@ def install_editable(self, install_options,

with indent_log():
# FIXME: should we do --install-headers here too?
call_subprocess(
[
sys.executable,
'-c',
SETUPTOOLS_SHIM % self.setup_py
] +
list(global_options) +
['develop', '--no-deps'] +
list(install_options),

cwd=self.setup_py_dir,
show_stdout=False,
)
with self.build_env:
call_subprocess(
[
sys.executable,
'-c',
SETUPTOOLS_SHIM % self.setup_py
] +
list(global_options) +
['develop', '--no-deps'] +
list(install_options),

cwd=self.setup_py_dir,
show_stdout=False,
)

self.install_succeeded = True

Expand Down
8 changes: 8 additions & 0 deletions tests/functional/test_install_reqs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,14 @@ def test_constraints_local_editable_install_causes_error(script, data):
assert 'Could not satisfy constraints for' in result.stderr


def test_constraints_local_editable_install_pep518(script, data):
to_install = data.src.join("pep518-3.0")

script.pip('download', 'setuptools', 'wheel', '-d', data.packages)
script.pip(
'install', '--no-index', '-f', data.find_links, '-e', to_install)


def test_constraints_local_install_causes_error(script, data):
script.scratch_path.join("constraints.txt").write(
"singlemodule==0.0.0"
Expand Down