Pip freeze of editable git repos reports repo path

news/4759.bugfix

@@ -0,0 +1,2 @@
+pip freeze now reports URL based on file system location for git
+repositories with no remotes.

src/pip/_internal/vcs/git.py

@@ -9,7 +9,7 @@
 from pip._vendor.six.moves.urllib import request as urllib_request
 
 from pip._internal.compat import samefile
-from pip._internal.exceptions import BadCommand
+from pip._internal.exceptions import BadCommand, InstallationError
 from pip._internal.utils.misc import display_path
 from pip._internal.utils.temp_dir import TempDirectory
 from pip._internal.vcs import VersionControl, vcs
@@ -203,17 +203,24 @@ def obtain(self, dest):
 
     def get_url(self, location):
         """Return URL of the first remote encountered."""
-        remotes = self.run_command(
-            ['config', '--get-regexp', r'remote\..*\.url'],
-            show_stdout=False, cwd=location,
-        )
-        remotes = remotes.splitlines()
-        found_remote = remotes[0]
-        for remote in remotes:
-            if remote.startswith('remote.origin.url '):
-                found_remote = remote
-                break
-        url = found_remote.split(' ')[1]
+        try:
+            remotes = self.run_command(
+                ['config', '--get-regexp', r'remote\..*\.url'],
+                show_stdout=False, cwd=location,
+            )
+        except InstallationError:
+            # If the above command fails we have no git remotes or cannot
+            # determine what they are. Just use the local repo path in that
+            # case instead.
+            url = 'file://' + location
+        else:
+            remotes = remotes.splitlines()
+            found_remote = remotes[0]
+            for remote in remotes:
+                if remote.startswith('remote.origin.url '):
+                    found_remote = remote
+                    break
+            url = found_remote.split(' ')[1]
         return url.strip()
 
     def get_revision(self, location):

tests/functional/test_freeze.py

@@ -320,6 +320,17 @@ def test_freeze_git_remote(script, tmpdir):
         """
     ).format(remote=origin_remote).strip()
     _check_output(result.stdout, expected)
+    # check when there are no remotes. Should report local file path.
+    script.run('git', 'remote', 'remove', 'origin', cwd=repo_dir)
+    script.run('git', 'remote', 'remove', 'other', cwd=repo_dir)
+    result = script.pip('freeze', expect_stderr=True)
+    expected = textwrap.dedent(
+        """
+            ...-e git+{remote}@...#egg=version_pkg
+            ...
+        """
+    ).format(remote='file://' + os.path.normcase(repo_dir)).strip()
+    _check_output(result.stdout, expected)
 
 
 @need_mercurial

tests/functional/test_install_vcs.py

@@ -291,21 +291,6 @@ def test_git_with_ambiguous_revs(script):
     result.assert_installed('version-pkg', with_files=['.git'])
 
 
-@pytest.mark.network
-def test_git_works_with_editable_non_origin_repo(script):
-    # set up, create a git repo and install it as editable from a local
-    # directory path
-    version_pkg_path = _create_test_package(script)
-    script.pip('install', '-e', version_pkg_path.abspath)
-
-    # 'freeze'ing this should not fall over, but should result in stderr output
-    # warning
-    result = script.pip('freeze', expect_stderr=True)
-    assert "Error when trying to get requirement" in result.stderr
-    assert "Could not determine repository location" in result.stdout
-    assert "version-pkg==0.1" in result.stdout
-
-
 @pytest.mark.network
 def test_reinstalling_works_with_editible_non_master_branch(script):
     """