Fix issue 12769 mimetypes windows error #13183
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egistry key inside `HKEY_CLASSES_ROOT` can't be accessed
ichard26
requested changes
Jan 26, 2025
Co-authored-by: Richard Si <[email protected]>
Co-authored-by: Richard Si <[email protected]>
ichard26
reviewed
Jan 27, 2025
| @@ -0,0 +1 @@ | |||
| Gracefully handle Windows registry access errors while guessing the MIME type of a file. | |||
There was a problem hiding this comment.
Note for other reviewers, while the code comment is more general because it seems guess_type() can fail on any platform (according to the docs), the only reports in practice are on Windows w/ the registry.
ichard26
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
So... I broke my Windows install while messing in the Registry Editor. Thankfully I had a system restore point so it wasn't a huge deal. I've double checked that the logic degrades gracefully when hard-coding an error, but I'm not going to try to reproduce the actual PermissionError :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12769 by ignoring the error
mimetypesraises and keepingcontent_typeasNone.The only function referencing this variable is
unpack_url(...)callingunpack_file()which already acceptsNoneas the content type as is.