Fix resolution to respect --python-version when checking Requires-Python
#12218
Conversation
| assert len(wheel_candidates) == 1, ( | ||
| f"Missing wheels in {common_wheels}, expected 1 got '{wheel_candidates}'." | ||
| " Are you running the tests via nox? See https://pip.pypa.io/en/latest/development/getting-started/#running-tests" | ||
| ) |
There was a problem hiding this comment.
Drive-by improvement, because my dumb self was trying to run pytest and didn't read the docs 😅
| "0.1.0", | ||
| requires_python="<3", | ||
| ) | ||
| result = script.pip( |
|
Marking this as a draft until you're able to get CI happy. :) Feel welcome to ask questions, if you have any! |
|
Yeah, that's just my comment above regarding failure (another CLI error regarding these flags) I have another issue/fix that this currently bumps into. Wanna go take a look at those? 🤓 |
|
CI now seems happy on other PRs... https://github.com/pypa/pip/actions |
|
Yeah, this PR fail CI until the dependent PR is merged. I called it out above: #12218 (comment) I don't think anyone has looked at that PR yet though... |
|
I’ve merged the depending PR to main and merged main into this one. |
|
Ok PR is ready to review! |
|
Thanks @thejcannon! Sorry about the delay, but better than never :) |
|
To be honest I forgot about it too 😂 |
Fixes #12216