Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if --hash is used on a line without requirement #11940

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Warn if --hash is used on a line without requirement #11940

merged 1 commit into from
Apr 10, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Apr 9, 2023

closes #11935

@sbidoul sbidoul mentioned this pull request Apr 9, 2023
Closed
@sbidoul sbidoul added this to the 23.1 milestone Apr 9, 2023
pfmoore
pfmoore approved these changes Apr 9, 2023
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm assuming this isn't worth a test).

@uranusjr uranusjr merged commit aebc0c5 into pypa:main Apr 10, 2023
@sbidoul sbidoul deleted the imp-req-file-parser-sbi branch April 10, 2023 09:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.

Missing continuation \ in requirement files cause hashes to be silently ignored
3 participants
@sbidoul @uranusjr @pfmoore