Make the root warning silence flag multi-state #11035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a flag, make the option take an argument like this:
--root-user-action=ignore
This allows us to add more alternatives in the future, for example to
emit a hard error when a root user is detected.
Also re-label the news fragment to point to the issue instead of the PR
that introduced the option.
pradyunsg
approved these changes
Apr 14, 2022
potiuk
reviewed
Apr 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a flag, make the option take an argument like this:
This allows us to add more alternatives in the future, for example to emit a hard error when a root user is detected. This makes #7802 a bit easier to transition.
Also re-label the news fragment to point to the issue instead of the PR that introduced the option.
Tentitively putting this into 21.1; this has not been released, so if we change it before 23.1 we can avoid any compatibility issues. After the release it’d be more difficult.
ref #10556 #10990
cc @potiuk