Skip to content

Commit

Permalink
Reword news entry
Browse files Browse the repository at this point in the history
  • Loading branch information
deveshks committed Jul 6, 2020
1 parent 04fedfe commit ac624f1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion news/5021.bugfix
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Package name should be normalized before we use it to search if it's already installed or not
Use canonical package names while looking up already installed packages.
2 changes: 0 additions & 2 deletions src/pip/_internal/commands/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from pip._internal.network.xmlrpc import PipXmlrpcTransport
from pip._internal.utils.compat import get_terminal_size
from pip._internal.utils.logging import indent_log

from pip._internal.utils.misc import get_distribution, write_output
from pip._internal.utils.typing import MYPY_CHECK_RUNNING

Expand All @@ -32,7 +31,6 @@
{'name': str, 'summary': str, 'versions': List[str]},
)


logger = logging.getLogger(__name__)


Expand Down
1 change: 0 additions & 1 deletion src/pip/_internal/req/req_install.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,6 @@ def check_if_exists(self, use_user_site):
"""
if self.req is None:
return

# get_distribution() will resolve the entire list of requirements
# anyway, and we've already determined that we need the requirement
# in question, so strip the marker so that we don't try to
Expand Down

0 comments on commit ac624f1

Please sign in to comment.