-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce packaging.tags #156
Conversation
First, add pytest as a dev requirement, else it won't run as its own command. Second, drop the dot. Third, use -m to help control which interpreter is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see this moving forward :-). A few comments below.
Are you planning to switch pip over to using this?
Just to set expectations, I'm probably not going to get to looking at this until Christmas-ish. It's significant new functionality and it'll take me a bit to ramp up on it. |
@dstufft Thanks for the update and no problem from my end. Have a happy holidays! |
OK, the PR now passes CI! Over to you, @dstufft 😁 |
Anything I can do to help move this forward, @dstufft ? Do you want me to break this up somewhat? I could do platform-independent stuff and then do separate PRs for Windows, Linux, and macOS if that would help get this reviewed. |
No, I just forgot about it. I'll take a look at it later this week. Thanks for the reminder! |
I now have a use for this at work, so I'm prodding again about what I can do to help get this reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments. I feel really bad about how long I left this sit, so feel free to push back on things if reworking them would require a bunch of additional effort. Overall I think the structure here is fairly reasonable.
@dstufft PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. This looks great ✨ Sorry that it took so long to get reviewed.
Thanks for landing this! And no problem about the time, just glad it worked out in the end. |
Add support for PEP 425: Compatibility Tags for Built Distributions.
Closes #83