Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Environment :: WebAssembly and Framework :: Pydantic to trove classifiers #725

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Jan 22, 2023

This was only very recently added in pypa/trove-classifiers#129.

Closes #727 (duplicate).

@matthewfeickert
Copy link
Contributor Author

@ofek this is ready for review whenever you have time.

@ofek
Copy link
Collaborator

ofek commented Jan 22, 2023

Can you please instead run this

update-classifiers = [
?

@matthewfeickert matthewfeickert force-pushed the feat/add-wasm-trove-classifiers branch from 8e65ba3 to 766a256 Compare January 22, 2023 21:49
@matthewfeickert matthewfeickert changed the title feat: Add Environment :: WebAssembly to trove classifiers feat: Add Environment :: WebAssembly and Framework :: Pydantic to trove classifiers Jan 22, 2023
@matthewfeickert
Copy link
Contributor Author

Yup. This now reflects the state of

$ hatch env run --env backend update-classifiers

@matthewfeickert
Copy link
Contributor Author

Similar to #724 (comment) it seems these are linting error failing on ruff unrelated to the PR. Though I can appreciate wanting to wait until those are fixed and rebasing this before merging.

@matthewfeickert matthewfeickert force-pushed the feat/add-wasm-trove-classifiers branch from 766a256 to 5b009f7 Compare January 26, 2023 14:13
@matthewfeickert
Copy link
Contributor Author

Now that PR #733 is in, this should pass CI (it does on my fork) and is ready for review.

Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💜

@matthewfeickert matthewfeickert force-pushed the feat/add-wasm-trove-classifiers branch from 5b009f7 to 4b8ea59 Compare January 26, 2023 14:47
@ofek ofek merged commit 2f685c7 into pypa:master Jan 26, 2023
@matthewfeickert matthewfeickert deleted the feat/add-wasm-trove-classifiers branch January 26, 2023 22:12
github-actions bot pushed a commit to blink1073/hatch that referenced this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants