-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nudge users to use Trusted Publishers when publishing to PyPI and TestPyPI #164
Comments
I like this idea, thanks 🙏 @woodruffw @di any comments/objections? I'm pretty much in favor unless there's something I overlooked.. |
I'm overall in favor, I think the message could be slightly improved, maybe something like:
|
Sounds good to me as well! |
I'm willing to quickly knock this out, unless @sethmlarson is already planning on it 😉 |
@woodruffw Please go ahead! 🚀 |
Closes pypa#164. Signed-off-by: William Woodruff <[email protected]>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) | action | patch | `v1.8.7` -> `v1.8.8` | --- ### Release Notes <details> <summary>pypa/gh-action-pypi-publish (pypa/gh-action-pypi-publish)</summary> ### [`v1.8.8`](https://github.com/pypa/gh-action-pypi-publish/releases/tag/v1.8.8) [Compare Source](https://github.com/pypa/gh-action-pypi-publish/compare/v1.8.7...v1.8.8) ##### 💅 Cosmetic output impovements - In [https://github.com/pypa/gh-action-pypi-publish/pull/167](https://github.com/pypa/gh-action-pypi-publish/pull/167), [@​woodruffw](https://github.com/woodruffw) introduced a nudge-warning encoraging people to start using secretless publishing to PyPI, as suggested by [@​sethmlarson] in [https://github.com/pypa/gh-action-pypi-publish/issues/164](https://github.com/pypa/gh-action-pypi-publish/issues/164), collaborating with [@​di](https://github.com/di). *:bulb: Tip:* The OIDC-based trusted publishing integration details can be found in the action README at https://github.com/marketplace/actions/pypi-publish#trusted-publishing and on the PyPI docs page at https://docs.pypi.org/trusted-publishers/. It's gone GA on April 20, 2023, during PyCon: https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/. And the Trail Of Bits blog post has some deeper explanation here: https://blog.trailofbits.com/2023/05/23/trusted-publishing-a-new-benchmark-for-packaging-security/. ##### 🛠️ Internal dependencies - [@​pquentin] bumped the runtime dependency pins to the recent versions @&#[https://github.com/pypa/gh-action-pypi-publish/pull/168](https://github.com/pypa/gh-action-pypi-publish/pull/168)ll/168. ##### 💪 New Contributors - [@​pquentin](https://github.com/pquentin) made their first contribution in [https://github.com/pypa/gh-action-pypi-publish/pull/168](https://github.com/pypa/gh-action-pypi-publish/pull/168) **:mirror: Full Diff**: pypa/gh-action-pypi-publish@v1.8.7...v1.8.8 [@​pquentin]: https://github.com/sponsors/pquentin [@​sethmlarson]: https://github.com/sponsors/sethmlarson </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) | action | patch | `v1.8.7` -> `v1.8.8` | --- ### Release Notes <details> <summary>pypa/gh-action-pypi-publish (pypa/gh-action-pypi-publish)</summary> ### [`v1.8.8`](https://github.com/pypa/gh-action-pypi-publish/releases/tag/v1.8.8) [Compare Source](https://github.com/pypa/gh-action-pypi-publish/compare/v1.8.7...v1.8.8) #### 💅 Cosmetic output impovements - In [https://github.com/pypa/gh-action-pypi-publish/pull/167](https://github.com/pypa/gh-action-pypi-publish/pull/167), [@​woodruffw](https://github.com/woodruffw) introduced a nudge-warning encoraging people to start using secretless publishing to PyPI, as suggested by [@​sethmlarson] in [https://github.com/pypa/gh-action-pypi-publish/issues/164](https://github.com/pypa/gh-action-pypi-publish/issues/164), collaborating with [@​di](https://github.com/di). *:bulb: Tip:* The OIDC-based trusted publishing integration details can be found in the action README at https://github.com/marketplace/actions/pypi-publish#trusted-publishing and on the PyPI docs page at https://docs.pypi.org/trusted-publishers/. It's gone GA on April 20, 2023, during PyCon: https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/. And the Trail Of Bits blog post has some deeper explanation here: https://blog.trailofbits.com/2023/05/23/trusted-publishing-a-new-benchmark-for-packaging-security/. #### 🛠️ Internal dependencies - [@​pquentin] bumped the runtime dependency pins to the recent versions @&#[https://github.com/pypa/gh-action-pypi-publish/pull/168](https://github.com/pypa/gh-action-pypi-publish/pull/168)ll/168. #### 💪 New Contributors - [@​pquentin](https://github.com/pquentin) made their first contribution in [https://github.com/pypa/gh-action-pypi-publish/pull/168](https://github.com/pypa/gh-action-pypi-publish/pull/168) **:mirror: Full Diff**: pypa/gh-action-pypi-publish@v1.8.7...v1.8.8 [@​pquentin]: https://github.com/sponsors/pquentin [@​sethmlarson]: https://github.com/sponsors/sethmlarson </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) | action | patch | `v1.8.7` -> `v1.8.8` | --- ### Release Notes <details> <summary>pypa/gh-action-pypi-publish (pypa/gh-action-pypi-publish)</summary> ### [`v1.8.8`](https://github.com/pypa/gh-action-pypi-publish/releases/tag/v1.8.8) [Compare Source](https://github.com/pypa/gh-action-pypi-publish/compare/v1.8.7...v1.8.8) #### 💅 Cosmetic output improvements - In [https://github.com/pypa/gh-action-pypi-publish/pull/167](https://github.com/pypa/gh-action-pypi-publish/pull/167), [@​woodruffw](https://github.com/woodruffw) introduced a nudge-warning encouraging people to start using secretless publishing to PyPI, as suggested by [@​sethmlarson] in [https://github.com/pypa/gh-action-pypi-publish/issues/164](https://github.com/pypa/gh-action-pypi-publish/issues/164), collaborating with [@​di](https://github.com/di). *:bulb: Tip:* The OIDC-based trusted publishing integration details can be found in the action README at https://github.com/marketplace/actions/pypi-publish#trusted-publishing and on the PyPI docs page at https://docs.pypi.org/trusted-publishers/. It's gone GA on April 20, 2023, during PyCon: https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/. And the Trail Of Bits blog post has some deeper explanation here: https://blog.trailofbits.com/2023/05/23/trusted-publishing-a-new-benchmark-for-packaging-security/. #### 🛠️ Internal dependencies - [@​pquentin] bumped the runtime dependency pins to the recent versions @&#[https://github.com/pypa/gh-action-pypi-publish/pull/168](https://github.com/pypa/gh-action-pypi-publish/pull/168)ll/168. #### 💪 New Contributors - [@​pquentin](https://github.com/pquentin) made their first contribution in [https://github.com/pypa/gh-action-pypi-publish/pull/168](https://github.com/pypa/gh-action-pypi-publish/pull/168) **:mirror: Full Diff**: pypa/gh-action-pypi-publish@v1.8.7...v1.8.8 [@​pquentin]: https://github.com/sponsors/pquentin [@​sethmlarson]: https://github.com/sponsors/sethmlarson </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
We can use a GitHub Action workflow command to send warnings to users in their workflows to nudge users towards enabling Trusted Publishers instead of username/password and API tokens.
How warnings appear in GitHub Actions
This warning message appears in the workflow execution and in the summary screen and can point users at the exact workflow file they need to modify in addition to linking out to documentation on how to use Trusted Publishers.
A hypothetical warning message being:
The warning shows up on the summary page for the GitHub Action execution:
The warning shows up inline in the logs as well:
The text was updated successfully, but these errors were encountered: