Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_mkpath_exception_uncached #316

Merged
merged 5 commits into from
Dec 26, 2024
Merged

Fix test_mkpath_exception_uncached #316

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c1bec6
Fix test_mkpath_exception_uncached
Avasam Nov 24, 2024
468532e
👹 Feed the hobgoblins (delint).
jaraco Dec 26, 2024
bbee59b
Use alternate spelling for flavor attribute.
jaraco Dec 26, 2024
a7fdc06
Only apply workaround on required Pythons.
jaraco Dec 26, 2024
01fbd65
Let pathlib resolve the flavor.
jaraco Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions distutils/tests/test_dir_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import os
import pathlib
import stat
import sys
import unittest.mock as mock
from distutils import dir_util, errors
from distutils.dir_util import (
Expand Down Expand Up @@ -106,8 +107,9 @@ def test_copy_tree_exception_in_listdir(self):
"""
An exception in listdir should raise a DistutilsFileError
"""
with mock.patch("os.listdir", side_effect=OSError()), pytest.raises(
errors.DistutilsFileError
with (
mock.patch("os.listdir", side_effect=OSError()),
pytest.raises(errors.DistutilsFileError),
):
src = self.tempdirs[-1]
dir_util.copy_tree(src, None)
Expand All @@ -123,6 +125,9 @@ class FailPath(pathlib.Path):
def mkdir(self, *args, **kwargs):
raise OSError("Failed to create directory")

if sys.version_info < (3, 12):
_flavour = pathlib.Path()._flavour

target = tmp_path / 'foodir'

with pytest.raises(errors.DistutilsFileError):
Expand Down
Loading