Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use reponses other than 'default' #14

Closed
mjgolinski opened this issue Dec 4, 2014 · 5 comments
Closed

Can't use reponses other than 'default' #14

mjgolinski opened this issue Dec 4, 2014 · 5 comments

Comments

@mjgolinski
Copy link

Responses other than 'default' are never selected by pyswagger.
After looking into code I realized you use returned status (int) as lookup, but schema is parsed from json, so keys in responses dict are strings. In json you can have only strings as keys.

@mission-liao
Copy link
Member

It is careless of me to leave such mistake, that also means I didn't write enough test cases. Another fix would be done later.

@mission-liao
Copy link
Member

btw, if possible, could you also provide a sample swagger.json you are working on for me to reference?

@mjgolinski
Copy link
Author

I’ll have to reconstruct it (I ditched it during development), so I’ll send it later

From: mission.liao [mailto:[email protected]]
Sent: Thursday, December 4, 2014 14:59
To: mission-liao/pyswagger
Cc: Golinski, Marcin J
Subject: Re: [pyswagger] Can't use reponses other than 'default' (#14)

btw, if possible, could you also provide a sample swagger.json you are working on for me to reference?

Reply to this email directly or view it on GitHub #14 (comment) .

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.

mission-liao added a commit that referenced this issue Dec 4, 2014
mission-liao added a commit that referenced this issue Dec 4, 2014
@mission-liao
Copy link
Member

Thanks, I just updated a hotfix to pypi for this issue and another one you reported.

@mjgolinski
Copy link
Author

I see now it's fixed. Thanks for quick response.
Do you still need this example file?

mission-liao added a commit to pyopenapi/pyopenapi that referenced this issue Aug 12, 2017
mission-liao added a commit to pyopenapi/pyopenapi that referenced this issue Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants