-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Respect yanked flag #208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ryanking13! I have just a few comments, the code looks good to me. Again, thanks for the reminder on Discord.
Co-authored-by: Agriya Khetarpal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ryanking13! This looks great now.
I do wonder if Codecov is helping us, as you previously mentioned a few days ago somewhere (I can't find that comment) that it misses a few lines that are actually covered, as it can't run the tests in a WASM environment. For example, it reports that YANKED_WARNING_MESSAGE
in line 244 of micropip/transaction.py
was not covered, but it's definitely there in the test_integration_install_yanked
case you added,
Nevertheless, maybe we can find a way to run coverage.py
in a WASM environment and use the HTML/Markdown reports it can generate, as I don't think sys.monitoring
needs any special attention in Pyodide. (Of course, not for this PR).
Yes, I think running coverage inside WASM is not that hard. The hard part would be merging the results of the coverage.py inside and outside Pyodide. |
Thanks for the review! |
Resolve: #146
Updates the resolver to respect
yanked
flag (PEP-592).If the version with the yanked flag set is found, it will be considered as a last resort, when all other versions are incompatible.