ENH Add support for reinstalling packages (take 2) #206
+469
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hoodmane
reviewed
Feb 20, 2025
micropip/install.py
Outdated
Comment on lines
69
to
71
| with indent_log(): | ||
| uninstall_distributions(distributions, logger) | ||
|
|
There was a problem hiding this comment.
Shouldn't this only happen if reinstall is True?
There was a problem hiding this comment.
The distributions parameter will always be an empty list if reinstall is false, as the transaction will not add any package that are already installed when reinstall is false.
But I think I can add that check just in case.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #51
Rebases #64.
This adds a new parameter,
reinstallto the micropip.install API.When the requested package is already installed in the system, and if it is not compatible:
reinstall== False (default): raises error.reinstall== True: uninstall the installed package and install the new one.