Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in loading package from local filesystem in Node #155

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Fix regression in loading package from local filesystem in Node #155

merged 3 commits into from
Nov 11, 2024

Conversation

ryanking13
Copy link
Member

There is a bug in micropip 0.7.0 that causes Node to fail to load packages from the local filesystem.

I also enabled Node CI to detect this kind of bug.

@ryanking13 ryanking13 mentioned this pull request Nov 10, 2024
Merged
hoodmane
hoodmane approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryanking13
Copy link
Member Author

Thanks for the review!

@ryanking13 ryanking13 merged commit 1fa0b52 into pyodide:main Nov 11, 2024
5 checks passed
@ryanking13 ryanking13 deleted the file-protocol branch November 11, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanking13 @hoodmane