Create a TsGroup from an iterable of Ts/Tsd objects #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem to make a ton of sense to me to require that users manually package their timestamp/series objects into a dict when creating
TsGroup
objects, since the keys are required to be unique integers. I would guess that the vast majority of the time, users would be just doing{0: ts0, 1: ts1, ...}
. Sure, this can be easily done by sayingdata = dict(enumerate(ts_list))
, but why not just allow the user to saydata = ts_list
and do the dict creation automatically?If the change described above is not desired, the second commit is probably still worth including. It ensures that the keys in
.data
and.index
are in the same order by doing this:This might not be assured if
bypass_check == True
.I added some tests for the new functionality. Again, any and all feedback/concerns/thoughts are welcome!