Signal processing v0 #300
Merged
Signal processing v0 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged main into dev |
|
Steps for linting are in the tox file. |
|
Note after quickly looking at the PR : pynapple uses numpy docstring not google docstring |
Docstings updated and linting fixed |
Codecov ReportAttention: Patch coverage is
|
BalzaniEdoardo
requested changes
Jun 8, 2024
gviejo
reviewed
Jun 10, 2024
Closed
kippfreud
force-pushed
the
signal_processing
branch
from
4cb6c0a to
4af8d90
Compare
gviejo
requested changes
Jul 2, 2024
gviejo
reviewed
Jul 9, 2024
| compute_spectogram computes fft on only a single epoch of data. This epoch be given with the ep | ||
| parameter otherwise will be sig.time_support, but it must only be a single epoch. | ||
| """ | ||
| if not isinstance(sig, (nap.Tsd, nap.TsdFrame)): |
There was a problem hiding this comment.
too bad, if we relied on XArrays instead of pandas we could allow TsdTensor
|
Great job. Thank you Kipp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains FFT and Wavelet decomposition support for pynapple objects. Some functions are based on those from pywavelets package, but have, at this point, been changed significantly