Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add TsGroup.merge_group method #275
[ENH] Add TsGroup.merge_group method #275
Changes from 3 commits
3da0d46
60719f5
b3874a1
d24f331
04a0053
c642068
2d08c33
26f6333
5c49a0e
58c3558
a65f5f5
6bf20a7
6988758
41e0dfc
e08c0e4
2225a2a
235d06e
92e0df4
e6c9bc5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is probably the most user facing method, I would have a nice numpydoc docstring here too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good suggestion. Could you offer some tips on how to do so while reducing redundancy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to move the detailed docstrings from the
merge_group
to themerge
.In
merge_group
keep the same initial paragraph describing the method, the parameters, and the returns sections. I'll add aSee Also
section that points tomerge
.