Fix client modbus function calls in remote by adding count as keyword argument #2563
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
requested changes
Feb 5, 2025
|
I updated the corresponding test file to use the keyword arguments implemented in the change. It might be necessary to overhaul the entire test file since other test functions might be outdated as well. But for now the CI completes fine :) |
janiversen
pushed a commit
that referenced
this pull request
Feb 7, 2025
… argument (#2563) Co-authored-by: phsete <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2562
Please provide feedback, it's my first contribution.