Switch to cache included in setup-python action #1513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bah, I'm going to rebase this on #1512 to avoid the mypy error. |
alexrudd2
force-pushed
the
actions-cache
branch
from
4e1573a to
47e8920
Compare
alexrudd2
changed the title
janiversen
reviewed
Apr 24, 2023
Yes, I had to start with the PR you just merged or the CI fails :). I am going to rebase again, which will drop the code change. |
|
Actually, this PR makes things slower because it only installs the downloads, not the install. actions/setup-python#330. Therefore, closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the GH actions CI uses
syphar/restore-virtualenv@v1to restore cache/restore pip dependencies.It should be possible to do this with
actions/setup-python@v4directly, since it has built-in caching.