Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLV Documentation Revisions #1419

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Conversation

ColtAllen
Copy link
Collaborator

@ColtAllen ColtAllen commented Jan 20, 2025

Description

  • Update reference links in docstrings for ModifiedBetaGeoModel
  • Update notebook links in Index and README (MBG/NBD links will work once 0.11.0 is released)
  • Update distribution block docstrings for BG/NBD and MBG/NBD

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1419.org.readthedocs.build/en/1419/

@ColtAllen ColtAllen added docs Improvements or additions to documentation CLV labels Jan 20, 2025
@ColtAllen ColtAllen added this to the 0.11.0 milestone Jan 20, 2025
@ColtAllen ColtAllen requested a review from juanitorduz January 20, 2025 20:49
@ColtAllen ColtAllen self-assigned this Jan 20, 2025
@github-actions github-actions bot added the tests label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (25d3529) to head (8b3e1c8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1419   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          49       49           
  Lines        5330     5330           
=======================================
  Hits         5041     5041           
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz mentioned this pull request Jan 20, 2025
2 tasks
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ColtAllen
Copy link
Collaborator Author

Made a quick edit to the CLV Quickstart notebook. Looks like some additional work is required to add support for the plot_expected_purchases_ppc function to BG/NBD and MBG/NBD. I'll create an issue for that, but once the checks pass and this is merged, we can release 0.11.0!

@ColtAllen ColtAllen merged commit 485a261 into pymc-labs:main Jan 21, 2025
18 of 20 checks passed
@ColtAllen ColtAllen deleted the clv_docs_revisions branch January 21, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV docs Improvements or additions to documentation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants