Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove media transformation registration functions #1378

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jan 15, 2025

Description

Remove the functions that are now part of the metaclass

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1378.org.readthedocs.build/en/1378/

@wd60622 wd60622 linked an issue Jan 15, 2025 that may be closed by this pull request
@wd60622 wd60622 requested a review from juanitorduz January 15, 2025 18:48
@github-actions github-actions bot added MMM good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance media transforms Related to adstock, saturation, and media transformations labels Jan 15, 2025
@github-actions github-actions bot added the tests label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.93%. Comparing base (16db682) to head (1a047ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
+ Coverage   93.92%   93.93%   +0.01%     
==========================================
  Files          48       48              
  Lines        5133     5129       -4     
==========================================
- Hits         4821     4818       -3     
+ Misses        312      311       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these deleting-code PRs 🙌

@juanitorduz juanitorduz merged commit 4e0c6e3 into main Jan 15, 2025
20 checks passed
@juanitorduz juanitorduz deleted the 1321-deprecate-media-transformation-registration branch January 15, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance media transforms Related to adstock, saturation, and media transformations MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate media transformation registration
2 participants