Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate to/from_json of Prior class in favor of to/from_dict #1338

Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jan 4, 2025

Description

The to/from_json methods are replaced with to/from_dict methods which has become a more standard method name.

They are a drop in replacement.

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1338.org.readthedocs.build/en/1338/

@wd60622 wd60622 linked an issue Jan 4, 2025 that may be closed by this pull request
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM tests Prior class customer choice Related to customer choice module enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package labels Jan 4, 2025
@wd60622 wd60622 requested a review from juanitorduz January 4, 2025 12:34
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.34%. Comparing base (c989eeb) to head (acde887).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/mmm/hsgp.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1338   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files          47       47           
  Lines        4963     4966    +3     
=======================================
+ Hits         4732     4735    +3     
  Misses        231      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz merged commit 3b95b77 into main Jan 5, 2025
19 of 20 checks passed
@juanitorduz juanitorduz deleted the 865-priorto_json-renamed-to-to_dict-and-implement-to_json branch January 5, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer choice Related to customer choice module docs Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package MMM Prior class tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prior.to_json renamed to to_dict and implement to_json
2 participants