keep date column in test_scale_lift_measurements #1316

malitsadok1 · 2024-12-25T19:16:21Z

Description

Related Issue

Closes time_varying_media and calibration #1312
Related to #

Checklist

Checked that the pre-commit linting/style checks pass
Included tests that prove the fix is effective or that the new feature works
Added necessary documentation (docstrings and/or example notebooks)
If you are a pro: each commit corresponds to a relevant logical change

Modules affected

MMM
CLV

Type of change

📚 Documentation preview 📚: https://pymc-marketing--1316.org.readthedocs.build/en/1316/

malitsadok1 · 2024-12-25T19:29:54Z

#1311

juanitorduz · 2024-12-25T19:34:49Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

pymc_marketing/mmm/lift_test.py

codecov · 2024-12-25T19:41:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (8d94482) to head (ce9d4c7).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1316   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          47       47           
  Lines        4995     4997    +2     
=======================================
+ Hits         4763     4765    +2     
  Misses        232      232

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juanitorduz · 2024-12-25T19:43:58Z

pymc_marketing/mmm/lift_test.py

+    else:
+        components = [df_lift_test_channel_scaled, df_target_scaled, df_sigma_scaled]
+
+    return pd.concat(components, axis=1)


It would be great if you could add a test. Maybe @wd60622 can help you with this (I do not know how easy is to add it into the current test-mocking flow :) )

wd60622

Thanks for making the change @malitsadok1 !

For a test, I think it would be suffice to show that the model with tvp_media can be built and add a lift test. If you are unfamiliar with pytest, let me know and I can help out.
Also make sure that any current tests will pass

wd60622 · 2024-12-26T11:33:31Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

tests/mmm/test_lift_test.py

tests/mmm/test_mmm.py

wd60622 · 2024-12-29T20:53:06Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

wd60622 · 2025-01-08T21:31:15Z

Hi @malitsadok1
How is this coming along? Let us know if you need a hand on this. We are happy to help out if needed

wd60622 · 2025-01-10T07:00:50Z

tests/mmm/test_lift_test.py

+    ).loc[
+        :,
+        ["channel", "x", "delta_x", "delta_y", "sigma"]
+        + (["date"] if "date" in df_lift_test_with_numerics.columns else []),


Is this ever not true?

@malitsadok1

wd60622 · 2025-01-10T07:01:52Z

Hi @malitsadok1
Do you have precommit installed in your dev setup?

malitsadok1 · 2025-01-10T09:37:56Z

no it's only one line of code I thought I can skip it but I try to add it *Mali Tsadok, Statistician* Bell Statistics LTD 0546206144/ ***@***.*** ***@***.***>

…

On Fri, Jan 10, 2025 at 9:02 AM Will Dean ***@***.***> wrote: Hi @malitsadok1 <https://github.com/malitsadok1> Do you have precommit installed in your dev setup? — Reply to this email directly, view it on GitHub <#1316 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6BIIAW4CC4PGGLE4SHOWBT2J5V7LAVCNFSM6AAAAABUGIODNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRHEZDGOJTGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

wd60622 · 2025-01-12T23:24:37Z

Yeah, it is easy to install and run. It should be easy to resolve this locally. If not, try the # type: ignore

wd60622

Thanks @malitsadok1

keep date column in test_scale_lift_measurements

69d140f

github-actions bot added the MMM label Dec 25, 2024

Merge branch 'main' into main

d748c05

juanitorduz requested a review from wd60622 December 25, 2024 19:34

[pre-commit.ci] auto fixes from pre-commit.com hooks

beab7f6

for more information, see https://pre-commit.ci

juanitorduz added the bug Something isn't working label Dec 25, 2024

juanitorduz reviewed Dec 25, 2024

View reviewed changes

pymc_marketing/mmm/lift_test.py Outdated Show resolved Hide resolved

juanitorduz reviewed Dec 25, 2024

View reviewed changes

malitsadok1 added 2 commits December 25, 2024 23:19

shorter version

c72aa5f

Merge branch 'main' of https://github.com/malitsadok1/pymc-marketing

0865dd7

wd60622 reviewed Dec 26, 2024

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

82b08c6

for more information, see https://pre-commit.ci

wd60622 changed the title ~~keep date column in test_scale_lift_measurements~~ keep date column in test_scale_lift_measurements Dec 28, 2024

add test for calibration + time_varying_media

b246730

github-actions bot added tests TVPs Related to time varying parameters lift tests labels Dec 29, 2024

wd60622 reviewed Dec 29, 2024

View reviewed changes

tests/mmm/test_lift_test.py Outdated Show resolved Hide resolved

wd60622 reviewed Dec 29, 2024

View reviewed changes

tests/mmm/test_mmm.py Outdated Show resolved Hide resolved

add try catch

dbdd2d8

wd60622 added this to the 0.11.0 milestone Dec 29, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

e04068c

for more information, see https://pre-commit.ci

fix syntax

ad4fd11

wd60622 reviewed Jan 10, 2025

View reviewed changes

Merge branch 'main' into main

23bc1b3

malitsadok1 and others added 2 commits January 14, 2025 00:19

fix syntax

eecb2e2

Merge branch 'main' into main

ce9d4c7

wd60622 approved these changes Jan 14, 2025

View reviewed changes

wd60622 merged commit 169eb1f into pymc-labs:main Jan 14, 2025
19 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keep date column in test_scale_lift_measurements #1316

keep date column in test_scale_lift_measurements #1316

malitsadok1 commented Dec 25, 2024 •

edited by wd60622

Loading

malitsadok1 commented Dec 25, 2024

juanitorduz commented Dec 25, 2024

codecov bot commented Dec 25, 2024 •

edited

Loading

juanitorduz Dec 25, 2024

wd60622 left a comment •

edited

Loading

wd60622 commented Dec 26, 2024

wd60622 commented Dec 29, 2024

wd60622 commented Jan 8, 2025

wd60622 Jan 10, 2025

wd60622 Jan 14, 2025

wd60622 commented Jan 10, 2025

malitsadok1 commented Jan 10, 2025 via email

wd60622 commented Jan 12, 2025

wd60622 left a comment

keep date column in test_scale_lift_measurements #1316

keep date column in test_scale_lift_measurements #1316

Conversation

malitsadok1 commented Dec 25, 2024 • edited by wd60622 Loading

Description

Related Issue

Checklist

Modules affected

Type of change

malitsadok1 commented Dec 25, 2024

juanitorduz commented Dec 25, 2024

codecov bot commented Dec 25, 2024 • edited Loading

Codecov Report

juanitorduz Dec 25, 2024

Choose a reason for hiding this comment

wd60622 left a comment • edited Loading

Choose a reason for hiding this comment

wd60622 commented Dec 26, 2024

wd60622 commented Dec 29, 2024

wd60622 commented Jan 8, 2025

wd60622 Jan 10, 2025

Choose a reason for hiding this comment

wd60622 Jan 14, 2025

Choose a reason for hiding this comment

wd60622 commented Jan 10, 2025

malitsadok1 commented Jan 10, 2025 via email

wd60622 commented Jan 12, 2025

wd60622 left a comment

Choose a reason for hiding this comment

malitsadok1 commented Dec 25, 2024 •

edited by wd60622

Loading

codecov bot commented Dec 25, 2024 •

edited

Loading

wd60622 left a comment •

edited

Loading