Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VariableFactory in FourierBase #1304

Merged
merged 7 commits into from
Dec 25, 2024

Conversation

aseyboldt
Copy link
Contributor

@aseyboldt aseyboldt commented Dec 20, 2024

@github-actions github-actions bot added the MMM label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (b3f740d) to head (d1362f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   95.13%   95.14%           
=======================================
  Files          44       44           
  Lines        4629     4633    +4     
=======================================
+ Hits         4404     4408    +4     
  Misses        225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you can line 328 to call to_dict if it exists instead of to_json

@wd60622 wd60622 added the enhancement New feature or request label Dec 20, 2024
@github-actions github-actions bot added the tests label Dec 25, 2024
@wd60622 wd60622 merged commit 8600ef3 into pymc-labs:main Dec 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants