Improved Default Priors for BetaGeoModel

[ColtAllen]

Description

This PR modifies the default model config of BetaGeoModel with a prior specification for the dropout process similar to that in BetaGeoBetaBinomModel. This improved parameter estimates and reduced fit times by 40-50% in testing.

Related Issue

• Closes Update default_model_config for BetaGeoModel #1123
• Related to Calculating CLV causing cluster to crash for not so large dataset #1077

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Modules affected

• MMM
• CLV

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pymc-marketing--1264.org.readthedocs.build/en/1264/

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (66a3f3c) to head (1613149).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   95.05%   95.06%           
=======================================
  Files          42       42           
  Lines        4451     4456    +5     
=======================================
+ Hits         4231     4236    +5     
  Misses        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wd60622]

can you add graphviz method instead of importing to close out #1138

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

wd60622 commented on 2024-12-14T05:29:20Z
----------------------------------------------------------------

How about just model? This makes me think that there is a different way to initialize a non-mcmc model.

But couldn't I use same model for multiple fits? that is:

python

model = clv.BetaGeoModel(data=data)

idata_mcmc = model.fit(method="mcmc")

idata_map = model.fit(method="map")

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

wd60622 commented on 2024-12-14T05:29:21Z
----------------------------------------------------------------

Can you explicitly say by adding "a" and "b" priors to the model_config

[ColtAllen]

can you add graphviz method instead of importing to close out #1138

I'll create another PR for this prior to merging this one. If it can be added to ModelBuilder I'd prefer to remove the existing MMM method.

[juanitorduz]

After addressing @wd60622 's comments we can merge this one :)

[ColtAllen]

can you add graphviz method instead of importing to close out #1138

I'll create another PR for this prior to merging this one. If it can be added to ModelBuilder I'd prefer to remove the existing MMM method.

#1284