Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Wrong legend in the posterior predictive plot then we set gradient=True #1212

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Nov 17, 2024

Fix wrong legend.

Before

image

After

image

(see example notebook diff)


📚 Documentation preview 📚: https://pymc-marketing--1212.org.readthedocs.build/en/1212/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM labels Nov 17, 2024
@juanitorduz juanitorduz requested a review from wd60622 November 17, 2024 20:45
@juanitorduz juanitorduz added the bug Something isn't working label Nov 17, 2024
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (3f33c32) to head (811973d).
Report is 125 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          39       39           
  Lines        4066     4066           
=======================================
  Hits         3887     3887           
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough. Looks good

@juanitorduz juanitorduz merged commit 00f84b9 into main Nov 18, 2024
13 checks passed
@juanitorduz juanitorduz deleted the fix-legend-gradient-posterior-predictive branch November 18, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants