Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving bug on optimization plot #1174

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

cetagostini
Copy link
Contributor

@cetagostini cetagostini commented Nov 6, 2024

Description

Running optimization notebook again and solving bug.

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1174.org.readthedocs.build/en/1174/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM labels Nov 6, 2024
Copy link

review-notebook-app bot commented Nov 6, 2024

View / edit / reply to this conversation on ReviewNB

juanitorduz commented on 2024-11-06T15:44:14Z
----------------------------------------------------------------

Line #1.    print(np.sum(list(mmm.optimal_allocation_dict.values())))

Can you please comment what is this cell for?


Copy link

review-notebook-app bot commented Nov 6, 2024

View / edit / reply to this conversation on ReviewNB

juanitorduz commented on 2024-11-06T15:44:15Z
----------------------------------------------------------------

Can you maybe make these plots less "tall"?


@juanitorduz
Copy link
Collaborator

Thanks @cetagostini ! Just a couple of small suggestions

@cetagostini
Copy link
Contributor Author

Done @juanitorduz modify the cell to have a more explicit print and make the plot less tall.

@juanitorduz juanitorduz merged commit e18f041 into main Nov 6, 2024
9 checks passed
@juanitorduz juanitorduz deleted the bug_on_optimization_plot branch November 6, 2024 18:19
@juanitorduz
Copy link
Collaborator

Thanks @cetagostini !

@juanitorduz juanitorduz added the bug Something isn't working label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants