Add plot_expected_purchases_over_time function
#1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColtAllen
added
docs
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
juanitorduz
reviewed
Oct 24, 2024
pymc_marketing/clv/plotting.py
Outdated
| ylabel: str = "Purchases", | ||
| ax: plt.Axes | None = None, | ||
| **kwargs, | ||
| ): |
There was a problem hiding this comment.
Can we add the return type hint plt.Axes (or shall we return the Figure object instead?, we do this for the MMM plots)
There was a problem hiding this comment.
All CLV plots return plt.Axes, but I do have some big plans coming up for this module, so we can leave it as-is for now.
juanitorduz
reviewed
Oct 24, 2024
juanitorduz
approved these changes
Oct 24, 2024
wd60622
reviewed
Oct 24, 2024
wd60622
reviewed
Oct 24, 2024
|
Thanks @ColtAllen ! |
ColtAllen
changed the title
plot_expected_purchases functionplot_expected_purchases_over_time function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates the
plot_cumulative_transactionsandplot_incremental_transactionsfunctions fromlifetimesinto a single plotting function, which is very useful for model evaluation:So useful in fact that when I added it to the Quickstart, it revealed a data discrepancy causing model bias! I left it in the notebook because I felt like it was a teachable moment, but at the same time we're showcasing this library with a skewed model. I'm curious to hear your thoughts on this.
I added
plt.clf()to the plotting function to reset thepyplotobject between plots, which is useful when logging multiple figures to MLflow. I also took the opportunity to make a few other revisions to the Quickstart, such as use of thePriorclass in model configs and a watermark.Related Issue
lifetimes#326Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--1115.org.readthedocs.build/en/1115/