Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for expected exception instead of xfail #1114

Merged
merged 11 commits into from
Oct 24, 2024
Merged

Test for expected exception instead of xfail #1114

merged 11 commits into from
Oct 24, 2024

Conversation

nhan295
Copy link
Contributor

@nhan295 nhan295 commented Oct 24, 2024 •
edited by wd60622
Loading

Description

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1114.org.readthedocs.build/en/1114/

@github-actions github-actions bot added the tests label Oct 24, 2024
@wd60622 wd60622 changed the title Closes #1109 Test for expected exception instead of xfail Oct 24, 2024
juanitorduz
juanitorduz requested changes Oct 24, 2024
View reviewed changes
@juanitorduz
Copy link
Collaborator

Thank you @nhan295 ! I think is almost there.

@github-actions github-actions bot added tests good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance labels Oct 24, 2024
@wd60622
Copy link
Contributor

wd60622 commented Oct 24, 2024

pre-commit.ci autofix

@nhan295 nhan295 requested a review from juanitorduz October 24, 2024 14:06
wd60622
wd60622 requested changes Oct 24, 2024
View reviewed changes
@wd60622
Copy link
Contributor

wd60622 commented Oct 24, 2024

pre-commit.ci autofix

@wd60622
Copy link
Contributor

wd60622 commented Oct 24, 2024

FYI @nhan295 run pre-commit install locally to get rid the pre-commit failures

@juanitorduz
Copy link
Collaborator

Thank you @nhan295 !

@juanitorduz juanitorduz merged commit 9b22791 into pymc-labs:main Oct 24, 2024
13 checks passed
@nhan295 nhan295 deleted the iamnhan branch October 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wd60622 wd60622 wd60622 requested changes

@juanitorduz juanitorduz juanitorduz approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance no releasenotes tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test for expected exception
3 participants
@nhan295 @juanitorduz @wd60622