Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numba 0.61 compatibility #1186

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 3, 2025

Did not see any change in performance running the existing benchmark tests on my machine

The __mm_cheap option was moved elsewhere in numba/numba@a5e2195

If anybody sees differences in performance it seems like the new internal API is controlled by setting _loopvect and _opt_level private attributes, so we could patch those, depending on the installed numba version (not very keen on this)

@ricardoV94 ricardoV94 requested a review from aseyboldt February 3, 2025 13:54
@ricardoV94 ricardoV94 added numba release bug Something isn't working labels Feb 3, 2025
Internal API changed in numba 0.61

Existing benchmarks don't show any difference in performance
@ricardoV94 ricardoV94 mentioned this pull request Feb 3, 2025
11 tasks
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (911c6a3) to head (c744636).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
- Coverage   82.30%   82.29%   -0.01%     
==========================================
  Files         186      186              
  Lines       48058    48039      -19     
  Branches     8633     8632       -1     
==========================================
- Hits        39552    39533      -19     
  Misses       6348     6348              
  Partials     2158     2158              
Files with missing lines Coverage Δ
pytensor/link/numba/dispatch/basic.py 81.08% <ø> (-0.55%) ⬇️
pytensor/link/numba/dispatch/elemwise.py 94.67% <100.00%> (-0.13%) ⬇️

@aseyboldt
Copy link
Member

I'm fine with just deleting those, they were a bit scary even if we ignore the version problems.

@ricardoV94 ricardoV94 merged commit 884dee9 into pymc-devs:main Feb 3, 2025
64 checks passed
@mathDR
Copy link

mathDR commented Feb 4, 2025

Thanks for jumping on this so quickly @ricardoV94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working numba release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants