Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating SymbolicRandomVariables inside CustomDist #6805

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 29, 2023

Some small maintenance for CustomDist


📚 Documentation preview 📚: https://pymc--6805.org.readthedocs.build/en/6805/

@ricardoV94 ricardoV94 changed the title Custom dist check Allow creating SymbolicRandomVariables inside CustomDist Jun 29, 2023
@ricardoV94 ricardoV94 changed the title Allow creating SymbolicRandomVariables inside CustomDist Allow creating SymbolicRandomVariables inside CustomDist Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #6805 (6031d26) into main (7b08fc1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6805      +/-   ##
==========================================
- Coverage   91.92%   91.91%   -0.02%     
==========================================
  Files          95       95              
  Lines       16197    16208      +11     
==========================================
+ Hits        14889    14897       +8     
- Misses       1308     1311       +3     
Impacted Files Coverage Δ
pymc/distributions/distribution.py 96.58% <100.00%> (ø)
pymc/util.py 80.42% <100.00%> (+0.08%) ⬆️

... and 5 files with indirect coverage changes

@ricardoV94 ricardoV94 merged commit 413af04 into pymc-devs:main Jun 29, 2023
@ricardoV94 ricardoV94 deleted the custom_dist_check branch September 18, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants