Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when compiling logp with mode="FAST_COMPILE" #6735

Merged
merged 2 commits into from
May 27, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 25, 2023

Closes #5618


📚 Documentation preview 📚: https://pymc--6735.org.readthedocs.build/en/6735/

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #6735 (1778f93) into main (8c93bb5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6735      +/-   ##
==========================================
- Coverage   92.00%   91.99%   -0.01%     
==========================================
  Files          95       95              
  Lines       16196    16204       +8     
==========================================
+ Hits        14901    14907       +6     
- Misses       1295     1297       +2     
Impacted Files Coverage Δ
pymc/logprob/basic.py 99.18% <100.00%> (+0.02%) ⬆️
pymc/logprob/rewriting.py 98.16% <100.00%> (+0.12%) ⬆️
pymc/logprob/transforms.py 94.54% <100.00%> (-0.41%) ⬇️

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoV94 ricardoV94 merged commit fbc62d5 into pymc-devs:main May 27, 2023
@ricardoV94 ricardoV94 deleted the fix_ir_issues branch June 5, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logp with transforms fails in FAST_COMPILE
2 participants