Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minibatch bugs #6730

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix minibatch bugs #6730

merged 2 commits into from
May 24, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 23, 2023

Closes #6560
Closes #6554


📚 Documentation preview 📚: https://pymc--6730.org.readthedocs.build/en/6730/

@ricardoV94 ricardoV94 added bug VI Variational Inference logprob labels May 23, 2023
@ricardoV94 ricardoV94 requested a review from ferrine May 23, 2023 17:23
@ricardoV94 ricardoV94 marked this pull request as ready for review May 23, 2023 17:23
@ricardoV94 ricardoV94 force-pushed the fix_minibatch_bugs branch from f88cfe2 to f5772af Compare May 23, 2023 17:24
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #6730 (fc9d72f) into main (cafb60b) will decrease coverage by 0.01%.
The diff coverage is 90.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6730      +/-   ##
==========================================
- Coverage   92.00%   92.00%   -0.01%     
==========================================
  Files          95       95              
  Lines       16190    16196       +6     
==========================================
+ Hits        14896    14901       +5     
- Misses       1294     1295       +1     
Impacted Files Coverage Δ
pymc/data.py 89.59% <83.33%> (-0.23%) ⬇️
pymc/logprob/basic.py 99.15% <100.00%> (ø)
pymc/logprob/rewriting.py 98.03% <100.00%> (ø)

@ricardoV94 ricardoV94 force-pushed the fix_minibatch_bugs branch from f5772af to fc9d72f Compare May 24, 2023 07:08
@ricardoV94 ricardoV94 merged commit 8c93bb5 into pymc-devs:main May 24, 2023
@ricardoV94 ricardoV94 deleted the fix_minibatch_bugs branch June 5, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug logprob VI Variational Inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minibatch with multiple variables is broken Assert that Minibatch batch_size is an integer
2 participants