Issue warning if RVs are present in derived probability graphs #6651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is problematic when using Potentials with derived quantities expressions, such as in:
Where
x
is not be replaced by the value variable in the Potential expression ofy
, leading to the wrong model logp.I couldn't think of a clean solution, so we just give an informative warning about the problem and suggestion on how to fix it.
Note that this is not a problem in
CustomDist
because the logp receives the value variables already instead of the random inputs.