Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue6004 fixed example in docstring for set_data #6028

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

rowan-schaefer
Copy link
Contributor

What is this PR about?
With @daniel-saunders-phil - Fixed example in docstring for set_data to account for code changes in latest version
...

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • ...

@@ -1870,7 +1870,7 @@ def set_data(new_data, model=None, *, coords=None):
>>> with model:
... pm.set_data({'x': [5., 6., 9.]})
... y_test = pm.sample_posterior_predictive(idata)
>>> y_test['obs'].mean(axis=0)
>>> y_test.posterior_predictive['obs'].mean(('chain', 'draw'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #6028 (407ce08) into main (b506fec) will increase coverage by 2.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6028      +/-   ##
==========================================
+ Coverage   86.64%   89.27%   +2.63%     
==========================================
  Files          72       72              
  Lines       12884    12884              
==========================================
+ Hits        11163    11502     +339     
+ Misses       1721     1382     -339     
Impacted Files Coverage Δ
pymc/model.py 88.20% <ø> (ø)
pymc/util.py 76.47% <0.00%> (-1.18%) ⬇️
pymc/step_methods/hmc/base_hmc.py 89.76% <0.00%> (-0.79%) ⬇️
pymc/backends/base.py 86.44% <0.00%> (+0.73%) ⬆️
pymc/step_methods/slicer.py 96.20% <0.00%> (+1.26%) ⬆️
pymc/backends/report.py 91.04% <0.00%> (+4.47%) ⬆️
pymc/step_methods/arraystep.py 94.32% <0.00%> (+7.80%) ⬆️
pymc/sampling.py 82.48% <0.00%> (+12.33%) ⬆️
pymc/step_methods/metropolis.py 83.36% <0.00%> (+43.65%) ⬆️

@canyon289
Copy link
Member

@rowangayleschaefer Thanks for the first contribution looks great!

@canyon289 canyon289 merged commit c93711a into pymc-devs:main Aug 5, 2022
@reshamas
Copy link
Contributor

reshamas commented Aug 6, 2022

#DataUmbrellaPyMCSprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants