Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docstrings to inform users that ODE solution may be slow. #5965

Merged
merged 2 commits into from
Jul 10, 2022

Conversation

dmburt
Copy link
Contributor

@dmburt dmburt commented Jul 9, 2022

Updated docstrings for init.py and pymc.ode.DifferentialEquation

Docstrings now provide additional information that ODE solution performance may be slow and provide a link to the sunode library (based on PyMC).

@reshamas
#DataUmbrellaPyMCSprint

@dmburt
Copy link
Contributor Author

dmburt commented Jul 9, 2022

Worked on solution with @azulcou

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #5965 (6f64540) into main (f617180) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5965      +/-   ##
==========================================
- Coverage   89.52%   89.38%   -0.15%     
==========================================
  Files          73       73              
  Lines       13271    13249      -22     
==========================================
- Hits        11881    11842      -39     
- Misses       1390     1407      +17     
Impacted Files Coverage Δ
pymc/ode/__init__.py 100.00% <ø> (ø)
pymc/ode/ode.py 85.85% <ø> (ø)
pymc/__init__.py 68.42% <0.00%> (-31.58%) ⬇️
pymc/data.py 81.48% <0.00%> (-0.16%) ⬇️
pymc/distributions/continuous.py 97.89% <0.00%> (-0.10%) ⬇️
pymc/distributions/logprob.py 97.72% <0.00%> (ø)
pymc/distributions/discrete.py 99.21% <0.00%> (ø)
pymc/step_methods/mlda.py 96.38% <0.00%> (+0.01%) ⬆️
pymc/model_graph.py 93.70% <0.00%> (+0.10%) ⬆️
pymc/model.py 88.20% <0.00%> (+0.14%) ⬆️

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmburt and @azulcou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants