Updated docstring for find_constrained_prior #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexAndorra you originally wrote this, correct? Can you take a look? It's for #DataUmbrellaPyMCSprint |
Co-authored-by: Michael Osthege <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5964 +/- ##
==========================================
- Coverage 89.41% 89.40% -0.01%
==========================================
Files 73 73
Lines 13292 13248 -44
==========================================
- Hits 11885 11845 -40
+ Misses 1407 1403 -4
|
OriolAbril
reviewed
Jul 11, 2022
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
|
Thanks @OriolAbril, this is useful. I will reference these formatting changes moving forward. |
cluhmann
reviewed
Jul 11, 2022
pymc/func_utils.py
Outdated
| PyMC distribution you want to set a prior on. | ||
| Needs to have a ``logcdf`` method implemented in PyMC. | ||
| lower : float | ||
| Lower bound to get `mass` % of probability of `pm_dist`. | ||
| upper : float | ||
| Upper bound to get `mass` % of probability of `pm_dist`. | ||
| init_guess: Dict[str, float] | ||
| init_guess : dict of {str : float} |
There was a problem hiding this comment.
Just need to trim this trailing whitespace.
jlindbloom
commented
Jul 11, 2022
|
LGTM. Just need a core dev to approve! |
michaelosthege
approved these changes
Jul 12, 2022
|
@jlindbloom |
|
I can't quite see what the whitespace CI failure is about. |
|
thanks @jlindbloom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Just updated the
find_constrained_priordocstring during the data umbrella sprint (with @bdatko).#DataUmbrellaPyMCSprint
Cc: @reshamas
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance
find_constrained_prior, following this guide.References
Towards #5459