Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of python-version specific conda environments #5911

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Get rid of python-version specific conda environments #5911

merged 3 commits into from
Jun 20, 2022

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 20, 2022 •
edited
Loading

This will probably fail spectacularly...

Related to #5074
Supersedes #5842

@ricardoV94 ricardoV94 force-pushed the get_rid_of_duplicated_environments branch 2 times, most recently from 4429968 to c1bef0a Compare June 20, 2022 10:46
@ricardoV94 ricardoV94 changed the title Get rid of duplicated environments Get rid of python version specific conda environments Jun 20, 2022
@ricardoV94 ricardoV94 mentioned this pull request Jun 20, 2022
Merged
@codecov
Copy link

codecov bot commented Jun 20, 2022 •
edited
Loading

Codecov Report

Merging #5911 (96b2bd7) into main (c180ae3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5911   +/-   ##
=======================================
  Coverage   89.50%   89.51%           
=======================================
  Files          73       73           
  Lines       13274    13274           
=======================================
+ Hits        11881    11882    +1     
+ Misses       1393     1392    -1
Impacted Files Coverage Δ
pymc/step_methods/hmc/base_hmc.py 90.47% <0.00%> (+0.79%) ⬆️

@ricardoV94 ricardoV94 marked this pull request as draft June 20, 2022 11:00
@ricardoV94 ricardoV94 force-pushed the get_rid_of_duplicated_environments branch from c1bef0a to f3aa561 Compare June 20, 2022 11:14
@ricardoV94 ricardoV94 force-pushed the get_rid_of_duplicated_environments branch 4 times, most recently from 82727e8 to 2941e7c Compare June 20, 2022 14:24
@ricardoV94 ricardoV94 force-pushed the get_rid_of_duplicated_environments branch from 2941e7c to 96b2bd7 Compare June 20, 2022 14:32
@ricardoV94 ricardoV94 marked this pull request as ready for review June 20, 2022 15:03
@ricardoV94
Copy link
Member Author

Seems to be working

@ricardoV94 ricardoV94 changed the title Get rid of python version specific conda environments Get rid of python-version specific conda environments Jun 20, 2022
@ricardoV94 ricardoV94 mentioned this pull request Jun 20, 2022
Closed
5 tasks
michaelosthege
michaelosthege approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of deleted lines. I like it.

@twiecki twiecki merged commit f602486 into pymc-devs:main Jun 20, 2022
@ricardoV94 ricardoV94 mentioned this pull request Jun 25, 2022
Closed
@danhphan danhphan mentioned this pull request Jun 29, 2022
Merged
@michaelosthege michaelosthege mentioned this pull request Jul 15, 2022
Open
@ricardoV94 ricardoV94 mentioned this pull request Sep 9, 2022
Closed
@ricardoV94 ricardoV94 deleted the get_rid_of_duplicated_environments branch June 6, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriolAbril OriolAbril OriolAbril left review comments

@twiecki twiecki twiecki approved these changes

@michaelosthege michaelosthege michaelosthege approved these changes

Assignees
No one assigned
Labels
Github CI/CD maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ricardoV94 @twiecki @michaelosthege @OriolAbril